Skip to content

Update sxa's email address to Red Hat from IBM #35442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update sxa's email address to Red Hat from IBM #35442

wants to merge 1 commit into from

Conversation

@sxa
Copy link
Member

@sxa sxa commented Oct 1, 2020

Change of employer so adjusting email address (and adding pronouns)

Signed-off-by: Stewart Addison [email protected]

Checklist

@sxa sxa added the doc Issues and PRs related to the documentations. label Oct 1, 2020
richardlau
richardlau approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sxa Do you want to update the .mailmap as well?

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 1, 2020
jasnell
jasnell approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-track?

@sxa
Copy link
Member Author

sxa commented Oct 1, 2020

Good shout @richardlau - now updated mailmap too

@sxa sxa force-pushed the sxa_redhat branch 2 times, most recently from 7e1d181 to f90bd6f Compare October 1, 2020 16:44
@sxa sxa self-assigned this Oct 1, 2020
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33366/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2020

Commit Queue failed
- Loading data for nodejs/node/pull/35442
✔  Done loading data for nodejs/node/pull/35442
----------------------------------- PR info ------------------------------------
Title      Update sxa's email address to Red Hat from IBM (#35442)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     sxa:sxa_redhat -> nodejs:master
Labels     doc, fast-track
Commits    1
 - doc: update sxa's email address to Red Hat from IBM
Committers 1
 - Stewart X Addison 
PR-URL: https://github.com/nodejs/node/pull/35442
Reviewed-By: Harshitha K P 
Reviewed-By: Richard Lau 
Reviewed-By: Ash Cripps 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35442
Reviewed-By: Harshitha K P 
Reviewed-By: Richard Lau 
Reviewed-By: Ash Cripps 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - doc: update sxa's email address to Red Hat from IBM
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-10-04T06:24:54Z: https://ci.nodejs.org/job/node-test-pull-request/33366/
- Querying data for job/node-test-pull-request/33366/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Thu, 01 Oct 2020 09:48:04 GMT
   ✔  Approvals: 6
   ✔  - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/35442#pullrequestreview-500201943
   ✔  - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35442#pullrequestreview-500536466
   ✔  - Ash Cripps (@AshCripps): https://github.com/nodejs/node/pull/35442#pullrequestreview-500281727
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35442#pullrequestreview-500357823
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/35442#pullrequestreview-500360211
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/35442#pullrequestreview-500445929
   ℹ  This PR is being fast-tracked
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 4, 2020
lpinca pushed a commit that referenced this pull request Oct 4, 2020
@lpinca
doc: update sxa's email address to Red Hat from IBM
190ee53 
Signed-off-by: Stewart Addison <[email protected]>

PR-URL: #35442
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@lpinca
Copy link
Member

lpinca commented Oct 4, 2020

Landed in 190ee53.

@lpinca lpinca closed this Oct 4, 2020
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
Merged
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@danielleadams
doc: update sxa's email address to Red Hat from IBM
1313c8c 
Signed-off-by: Stewart Addison <[email protected]>

PR-URL: #35442
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@MylesBorins
doc: update sxa's email address to Red Hat from IBM
d55b75a 
Signed-off-by: Stewart Addison <[email protected]>

PR-URL: #35442
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@MylesBorins
doc: update sxa's email address to Red Hat from IBM
370f8e3 
Signed-off-by: Stewart Addison <[email protected]>

PR-URL: #35442
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@joesepi
doc: update sxa's email address to Red Hat from IBM
e683979 
Signed-off-by: Stewart Addison <[email protected]>

PR-URL: nodejs#35442
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

+1 more reviewer

@AshCripps AshCripps AshCripps approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sxa sxa

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@sxa @nodejs-github-bot @lpinca @jasnell @Trott @cjihrig @richardlau @AshCripps @HarshithaKP @targos